fix: handle null y0 values on y log scale rendering #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=========================================
- Coverage 97.95% 97.85% -0.1%
=========================================
Files 39 39
Lines 2888 2894 +6
Branches 693 700 +7
=========================================
+ Hits 2829 2832 +3
- Misses 52 55 +3
Partials 7 7
Continue to review full report at Codecov.
|
markov00
changed the title
nickofthyme
approved these changes
Oct 10, 2019
markov00
changed the title
markov00
changed the title
markov00
pushed a commit
that referenced
this pull request
Oct 10, 2019
## [13.5.2](v13.5.1...v13.5.2) (2019-10-10) ### Bug Fixes * handle null y0 values on y log scale rendering ([#413](#413)) ([5731c10](5731c10))
|
🎉 This PR is included in version 13.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [13.5.2](elastic/elastic-charts@v13.5.1...v13.5.2) (2019-10-10) ### Bug Fixes * handle null y0 values on y log scale rendering ([opensearch-project#413](elastic/elastic-charts#413)) ([e20e9eb](elastic/elastic-charts@e20e9eb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The y0 value of each bar is
nullby default if we don't have a y0 value. With a log scale we were not check for that null value, creating an invalid height value for the bars. The same happens with other scale type.The issue (two bars should be displayed):
The fix:
I've also fixed a small issue in a story with a wrong data set
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials